From 6ae1ba0a647787420edc156d842de61d4e7114f0 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sat, 4 Sep 2021 17:55:58 -0600 Subject: [PATCH] Update StoryService, fix division by zero bug --- app/Services/StoryService.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Services/StoryService.php b/app/Services/StoryService.php index f44828899..dd53213c1 100644 --- a/app/Services/StoryService.php +++ b/app/Services/StoryService.php @@ -121,9 +121,9 @@ class StoryService 'sum' => (int) Story::sum('size'), 'average' => (int) Story::avg('size') ], - 'avg_spu' => (int) ($total / Story::groupBy('profile_id')->pluck('profile_id')->count()), + 'avg_spu' => $total ? (int) ($total / Story::groupBy('profile_id')->pluck('profile_id')->count()) : 'N/A', 'avg_duration' => (int) floor(Story::avg('duration')), - 'avg_type' => Story::selectRaw('type, count(id) as count')->groupBy('type')->orderByDesc('count')->first()->type + 'avg_type' => $total ? Story::selectRaw('type, count(id) as count')->groupBy('type')->orderByDesc('count')->first()->type : 'N/A' ]; }); }