Update UnfollowPipeline, fix follower count cache bug

This commit is contained in:
Daniel Supernault 2024-04-06 03:29:17 -06:00
parent 858fcbf606
commit 6bdf73de4d
No known key found for this signature in database
GPG key ID: 23740873EE6F76A1

View file

@ -4,26 +4,25 @@ namespace App\Jobs\FollowPipeline;
use App\Follower;
use App\FollowRequest;
use App\Jobs\HomeFeedPipeline\FeedUnfollowPipeline;
use App\Notification;
use App\Profile;
use App\Services\AccountService;
use App\Services\FollowerService;
use App\Services\NotificationService;
use Cache;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Log;
use Illuminate\Support\Facades\Redis;
use App\Services\AccountService;
use App\Services\FollowerService;
use App\Services\NotificationService;
use App\Jobs\HomeFeedPipeline\FeedUnfollowPipeline;
class UnfollowPipeline implements ShouldQueue
{
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
protected $actor;
protected $target;
/**
@ -48,11 +47,11 @@ class UnfollowPipeline implements ShouldQueue
$target = $this->target;
$actorProfile = Profile::find($actor);
if(!$actorProfile) {
if (! $actorProfile) {
return;
}
$targetProfile = Profile::find($target);
if(!$targetProfile) {
if (! $targetProfile) {
return;
}
@ -60,37 +59,37 @@ class UnfollowPipeline implements ShouldQueue
FollowerService::remove($actor, $target);
$actorProfileSync = Cache::get(FollowerService::FOLLOWING_SYNC_KEY . $actor);
if(!$actorProfileSync) {
$actorProfileSync = Cache::get(FollowerService::FOLLOWING_SYNC_KEY.$actor);
if (! $actorProfileSync) {
FollowServiceWarmCache::dispatch($actor)->onQueue('low');
} else {
if($actorProfile->following_count) {
if ($actorProfile->following_count) {
$actorProfile->decrement('following_count');
} else {
$count = Follower::whereProfileId($actor)->count();
$actorProfile->following_count = $count;
$actorProfile->save();
}
Cache::put(FollowerService::FOLLOWING_SYNC_KEY . $actor, 1, 604800);
Cache::put(FollowerService::FOLLOWING_SYNC_KEY.$actor, 1, 604800);
AccountService::del($actor);
}
$targetProfileSync = Cache::get(FollowerService::FOLLOWERS_SYNC_KEY . $target);
if(!$targetProfileSync) {
$targetProfileSync = Cache::get(FollowerService::FOLLOWERS_SYNC_KEY.$target);
if (! $targetProfileSync) {
FollowServiceWarmCache::dispatch($target)->onQueue('low');
} else {
if($targetProfile->followers_count) {
if ($targetProfile->followers_count) {
$targetProfile->decrement('followers_count');
} else {
$count = Follower::whereFollowingId($target)->count();
$targetProfile->followers_count = $count;
$targetProfile->save();
}
Cache::put(FollowerService::FOLLOWERS_SYNC_KEY . $target, 1, 604800);
Cache::put(FollowerService::FOLLOWERS_SYNC_KEY.$target, 1, 604800);
AccountService::del($target);
}
if($targetProfile->domain == null) {
if ($targetProfile->domain == null) {
Notification::withTrashed()
->whereProfileId($target)
->whereAction('follow')
@ -98,20 +97,22 @@ class UnfollowPipeline implements ShouldQueue
->whereItemId($target)
->whereItemType('App\Profile')
->get()
->each(function($n) {
->each(function ($n) {
NotificationService::del($n->profile_id, $n->id);
$n->forceDelete();
});
}
if($actorProfile->domain == null && config('instance.timeline.home.cached')) {
Cache::forget('pf:timelines:home:' . $actor);
if ($actorProfile->domain == null && config('instance.timeline.home.cached')) {
Cache::forget('pf:timelines:home:'.$actor);
}
FollowRequest::whereFollowingId($target)
->whereFollowerId($actor)
->delete();
return;
AccountService::del($target);
AccountService::del($actor);
}
}