From 493c5ca0ce1a3c8531df5dcf088bbde6495e8f26 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 19 Dec 2021 00:43:09 -0700 Subject: [PATCH 1/4] Add DiscoverService --- app/Services/DiscoverService.php | 36 ++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 app/Services/DiscoverService.php diff --git a/app/Services/DiscoverService.php b/app/Services/DiscoverService.php new file mode 100644 index 000000000..6f4acfc01 --- /dev/null +++ b/app/Services/DiscoverService.php @@ -0,0 +1,36 @@ +subMonths(3)); + return Status::select( + 'id', + 'is_nsfw', + 'profile_id', + 'type', + 'uri', + ) + ->whereNull('uri') + ->whereType('photo') + ->whereIsNsfw(false) + ->whereVisibility('public') + ->where('id', '>', $min_id) + ->inRandomOrder() + ->take(300) + ->pluck('id'); + } + + public static function getForYou() + { + return Cache::remember('pf:services:discover:for-you', 21600, function() { + return self::getDailyIdPool(); + }); + } +} From f36da7816f924c81d6eff8f4a276955e64d0707b Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 19 Dec 2021 00:48:05 -0700 Subject: [PATCH 2/4] Update InternalApiController, use DiscoverService for discoverPosts method --- .../Controllers/InternalApiController.php | 62 +++++-------------- 1 file changed, 17 insertions(+), 45 deletions(-) diff --git a/app/Http/Controllers/InternalApiController.php b/app/Http/Controllers/InternalApiController.php index 6f0cbfc6a..a8586d12d 100644 --- a/app/Http/Controllers/InternalApiController.php +++ b/app/Http/Controllers/InternalApiController.php @@ -41,6 +41,8 @@ use App\Services\ModLogService; use App\Services\PublicTimelineService; use App\Services\SnowflakeService; use App\Services\StatusService; +use App\Services\UserFilterService; +use App\Services\DiscoverService; class InternalApiController extends Controller { @@ -67,51 +69,21 @@ class InternalApiController extends Controller public function discoverPosts(Request $request) { - $profile = Auth::user()->profile; - $pid = $profile->id; - $following = Cache::remember('feature:discover:following:'.$pid, now()->addMinutes(15), function() use ($pid) { - return Follower::whereProfileId($pid)->pluck('following_id')->toArray(); - }); - $filters = Cache::remember("user:filter:list:$pid", now()->addMinutes(15), function() use($pid) { - $private = Profile::whereIsPrivate(true) - ->orWhere('unlisted', true) - ->orWhere('status', '!=', null) - ->pluck('id') - ->toArray(); - $filters = UserFilter::whereUserId($pid) - ->whereFilterableType('App\Profile') - ->whereIn('filter_type', ['mute', 'block']) - ->pluck('filterable_id') - ->toArray(); - return array_merge($private, $filters); - }); - $following = array_merge($following, $filters); - - $sql = config('database.default') !== 'pgsql'; - $min_id = SnowflakeService::byDate(now()->subMonths(3)); - $posts = Status::select( - 'id', - 'is_nsfw', - 'profile_id', - 'type', - 'uri', - ) - ->whereNull('uri') - ->whereIn('type', ['photo','photo:album', 'video']) - ->whereIsNsfw(false) - ->whereVisibility('public') - ->whereNotIn('profile_id', $following) - ->where('id', '>', $min_id) - ->inRandomOrder() - ->take(39) - ->pluck('id'); - - $res = [ - 'posts' => $posts->map(function($post) { - return StatusService::get($post); - }) - ]; - return response()->json($res); + $pid = $request->user()->profile_id; + $filters = UserFilterService::filters($pid); + $forYou = DiscoverService::getForYou(); + $posts = $forYou->random(50)->map(function($post) { + return StatusService::get($post); + }) + ->filter(function($post) use($filters) { + return $post && + isset($post['account']) && + isset($post['account']['id']) && + !in_array($post['account']['id'], $filters); + }) + ->take(12) + ->values(); + return response()->json(compact('posts')); } public function directMessage(Request $request, $profileId, $threadId) From 367d74fbfbf856deaff3d8c2f1ab478c9c753062 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 19 Dec 2021 00:48:59 -0700 Subject: [PATCH 3/4] Update ApiV1Controller, use DiscoverService for discoverPosts method --- app/Http/Controllers/Api/ApiV1Controller.php | 105 ++++++++----------- 1 file changed, 42 insertions(+), 63 deletions(-) diff --git a/app/Http/Controllers/Api/ApiV1Controller.php b/app/Http/Controllers/Api/ApiV1Controller.php index 1600fa20f..7b8dfa403 100644 --- a/app/Http/Controllers/Api/ApiV1Controller.php +++ b/app/Http/Controllers/Api/ApiV1Controller.php @@ -45,6 +45,7 @@ use App\Jobs\AvatarPipeline\AvatarOptimize; use App\Jobs\CommentPipeline\CommentPipeline; use App\Jobs\LikePipeline\LikePipeline; use App\Jobs\SharePipeline\SharePipeline; +use App\Jobs\SharePipeline\UndoSharePipeline; use App\Jobs\StatusPipeline\NewStatusPipeline; use App\Jobs\StatusPipeline\StatusDelete; use App\Jobs\FollowPipeline\FollowPipeline; @@ -57,8 +58,9 @@ use App\Jobs\VideoPipeline\{ use App\Services\{ AccountService, - LikeService, + FollowerService, InstanceService, + LikeService, NotificationService, MediaPathService, PublicTimelineService, @@ -74,6 +76,7 @@ use App\Util\Lexer\Autolink; use App\Util\Localization\Localization; use App\Util\Media\License; use App\Jobs\MediaPipeline\MediaSyncLicensePipeline; +use App\Services\DiscoverService; class ApiV1Controller extends Controller { @@ -1317,7 +1320,7 @@ class ApiV1Controller extends Controller $settings = UserSetting::whereUserId($user->id)->first(); if($settings && !empty($settings->compose_settings)) { - $compose = json_decode($settings->compose_settings, true); + $compose = $settings->compose_settings; if(isset($compose['default_license']) && $compose['default_license'] != 1) { $license = $compose['default_license']; @@ -1790,18 +1793,23 @@ class ApiV1Controller extends Controller $user = $request->user(); - $status = Status::findOrFail($id); + $res = StatusService::get($id, false); + if(!$res || !isset($res['visibility'])) { + abort(404); + } - if($status->profile_id !== $user->profile_id) { - if($status->scope == 'private') { - abort_if(!$status->profile->followedBy($user->profile), 403); + $scope = $res['visibility']; + if(!in_array($scope, ['public', 'unlisted'])) { + if($scope === 'private') { + if($res['account']['id'] != $user->profile_id) { + abort_unless(FollowerService::follows($user->profile_id, $res['account']['id']), 403); + } } else { - abort_if(!in_array($status->scope, ['public','unlisted']), 403); + abort(400, 'Invalid request'); } } - $res = StatusService::get($status->id); - $res['favourited'] = LikeService::liked($user->profile_id, $status->id); + $res['favourited'] = LikeService::liked($user->profile_id, $res['id']); $res['reblogged'] = false; return response()->json($res); } @@ -2069,7 +2077,9 @@ class ApiV1Controller extends Controller $status->in_reply_to_profile_id = $parent->profile_id; $status->save(); StatusService::del($parent->id); - } else if($ids) { + } + + if($ids) { if(Media::whereUserId($user->id) ->whereNull('status_id') ->find($ids) @@ -2077,12 +2087,15 @@ class ApiV1Controller extends Controller ) { abort(400, 'Invalid media_ids'); } - $status = new Status; - $status->caption = strip_tags($request->input('status')); - $status->profile_id = $user->profile_id; - $status->scope = 'draft'; - $status->is_nsfw = $user->profile->cw == true ? true : $request->input('sensitive', false); - $status->save(); + + if(!$in_reply_to_id) { + $status = new Status; + $status->caption = strip_tags($request->input('status')); + $status->profile_id = $user->profile_id; + $status->scope = 'draft'; + $status->is_nsfw = $user->profile->cw == true ? true : $request->input('sensitive', false); + $status->save(); + } $mimes = []; @@ -2230,6 +2243,7 @@ class ApiV1Controller extends Controller UndoSharePipeline::dispatch($reblog); $resource = new Fractal\Resource\Item($status, new StatusTransformer()); $res = $this->fractal->createData($resource)->toArray(); + $res['reblogged'] = false; return response()->json($res); } @@ -2429,55 +2443,20 @@ class ApiV1Controller extends Controller ]); $limit = $request->input('limit', 40); - $profile = Auth::user()->profile; - $pid = $profile->id; - - $following = Cache::remember('feature:discover:following:'.$pid, now()->addMinutes(15), function() use ($pid) { - return Follower::whereProfileId($pid)->pluck('following_id')->toArray(); - }); - - $filters = Cache::remember("user:filter:list:$pid", now()->addMinutes(15), function() use($pid) { - $private = Profile::whereIsPrivate(true) - ->orWhere('unlisted', true) - ->orWhere('status', '!=', null) - ->pluck('id') - ->toArray(); - $filters = UserFilter::whereUserId($pid) - ->whereFilterableType('App\Profile') - ->whereIn('filter_type', ['mute', 'block']) - ->pluck('filterable_id') - ->toArray(); - return array_merge($private, $filters); - }); - $following = array_merge($following, $filters); - - $sql = config('database.default') !== 'pgsql'; - $min_id = SnowflakeService::byDate(now()->subMonths(3)); - $res = Status::select( - 'id', - 'is_nsfw', - 'profile_id', - 'type', - 'uri', - ) - ->whereNull('uri') - ->whereIn('type', ['photo','photo:album', 'video']) - ->whereIsNsfw(false) - ->whereVisibility('public') - ->whereNotIn('profile_id', $following) - ->where('id', '>', $min_id) - ->inRandomOrder() - ->take($limit) - ->pluck('id') - ->map(function($post) { + $pid = $request->user()->profile_id; + $filters = UserFilterService::filters($pid); + $forYou = DiscoverService::getForYou(); + $posts = $forYou->random(50)->map(function($post) { return StatusService::get($post); }) - ->filter(function($post) { - return $post && isset($post['id']); + ->filter(function($post) use($filters) { + return $post && + isset($post['account']) && + isset($post['account']['id']) && + !in_array($post['account']['id'], $filters); }) - ->values() - ->toArray(); - - return response()->json($res); + ->take(12) + ->values(); + return response()->json(compact('posts')); } } From 0aad8d5934d706d9028d6478bd64461d4e5a244c Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Sun, 19 Dec 2021 00:51:57 -0700 Subject: [PATCH 4/4] Fix typo in api route --- routes/api.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/routes/api.php b/routes/api.php index fdcb0d4b0..fde9963de 100644 --- a/routes/api.php +++ b/routes/api.php @@ -79,9 +79,9 @@ Route::group(['prefix' => 'api'], function() use($middleware) { Route::get('timelines/home', 'Api\ApiV1Controller@timelineHome')->middleware($middleware); Route::get('timelines/public', 'Api\ApiV1Controller@timelinePublic')->middleware($middleware); - Route::get('timelines/tag/{hashtag}', 'Api\ApiV1Controller@timelineHashtag'); - Route::get('discover/posts', 'Api\ApiV1Controlle@discoverPosts')->middleware($middleware); - }); + Route::get('timelines/tag/{hashtag}', 'Api\ApiV1Controller@timelineHashtag'); + Route::get('discover/posts', 'Api\ApiV1Controller@discoverPosts')->middleware($middleware); + }); Route::group(['prefix' => 'v2'], function() use($middleware) { Route::get('search', 'Api\ApiV1Controller@searchV2')->middleware($middleware);