YGGverse/Yoda
1
0
Fork 0
mirror of https://github.com/YGGverse/Yoda.git synced 2026-03-31 16:45:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix page entity operations

Browse source
This commit is contained in:
yggverse 2024-07-12 20:16:31 +03:00
parent 7be7717897
commit f65458ca70
2 changed files with 13 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

35
src/Entity/Browser/Container/Tab.php
View file

@ -75,8 +75,8 @@ class Tab
?\GtkWidget $child,
int $page_num
) {
$this->closePage(
$page_num
$this->reorderPage(
null // all
);
}
);
@ -88,7 +88,9 @@ class Tab
?\GtkWidget $child,
int $page_num
) {
$this->reorderPage();
$this->reorderPage(
null // all
);
}
);
}
@ -168,30 +170,17 @@ class Tab
}
public function closePage(
int $page_num
?int $page_num = null
): void
{
// Validate page index exists
if (empty($this->_page[$page_num]))
if ($page = $this->getPage($page_num))
{
throw new \Exception;
$this->gtk->remove_page(
$this->gtk->page_num(
$page->gtk
)
);
}
// Remove GTK node
$this->gtk->remove_page(
$page_num
);
/*
// Free memory
$this->_page[$page_num] = null;
// Cleanup internal record
unset(
$this->_page[$page_num]
);
*/
// Reorder
$this->reorderPage();
}
public function reorderPage(

4
src/Entity/Browser/Menu/Tab/Close.php
View file

@ -34,10 +34,8 @@ class Close
function()
{
$this->tab->menu->browser->container->tab->closePage(
$this->tab->menu->browser->container->tab->gtk->get_current_page()
null // active
);
// @TODO unset page entity
}
);
}