From 09d27d5075c19dff8faa3bcf4bd375625a7db1cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Frosteg=C3=A5rd?= Date: Sun, 19 Jul 2020 13:27:54 +0200 Subject: [PATCH] Update TODO --- TODO.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/TODO.md b/TODO.md index 10e329b..0084382 100644 --- a/TODO.md +++ b/TODO.md @@ -9,13 +9,18 @@ and maybe run scripts should be adjusted ## aquatic_http -* request parsing: tests of main function and the various helper functions +* request parsing: + * tests of main function and the various helper functions + * hashmap needs ddos protecting hash function, or keys could be checked + against list before insertion + * deserialize 20 bytes: possibly rewrite (just check length of underlying + bytes == 20 and then copy them), also maybe remove String from map for + these cases too * test torrent transfer with real clients * test tls * current serialized byte strings valid * scrape: does it work (serialization etc), and with multiple hashes? * compact=0 should result in error response -* tests of request parsing * tests of response serialization (against data known to be good would be nice) * Connection.send_response: handle case when all bytes are not written: can write actually block here? And what action should be taken then? @@ -43,6 +48,11 @@ back to requirecrypto peers. Doesn't really work according to reference in https://en.wikipedia.org/wiki/BitTorrent_protocol_encryption +### don't do + +* request from path: only urldecode peer_id and info_hash: doesn't really + improve performance + ## aquatic_ws * is 'key' sent in announce request? if so, maybe handle it like in aquatic_http (including ip uniqueness part of peer map key)