mirror of
https://github.com/YGGverse/aquatic.git
synced 2026-03-31 17:55:36 +00:00
aquatic_ws network: don't send error response when message parse fails
This commit is contained in:
parent
f32cb522e2
commit
1e66b18e52
2 changed files with 7 additions and 1 deletions
3
TODO.md
3
TODO.md
|
|
@ -6,6 +6,9 @@
|
|||
* aquatic_http
|
||||
* aquatic_ws, including sending back new error responses
|
||||
|
||||
* aquatic_ws: should it send back error on message parse error, or does that
|
||||
just indicate that not enough data has been received yet?
|
||||
|
||||
* Consider turning on safety and override flags in mimalloc, mostly for
|
||||
simd-json. It might be faster to just stop using simd-json if I consider
|
||||
it insecure, which it maybe isn't.
|
||||
|
|
|
|||
|
|
@ -237,7 +237,9 @@ pub fn run_handshakes_and_read_messages(
|
|||
error!("InMessageSender: couldn't send message: {:?}", err);
|
||||
}
|
||||
}
|
||||
Err(err) => {
|
||||
Err(_) => {
|
||||
// FIXME: maybe this condition just occurs when enough data hasn't been recevied?
|
||||
/*
|
||||
info!("error parsing message: {:?}", err);
|
||||
|
||||
let out_message = OutMessage::ErrorResponse(ErrorResponse {
|
||||
|
|
@ -247,6 +249,7 @@ pub fn run_handshakes_and_read_messages(
|
|||
});
|
||||
|
||||
local_responses.push((meta, out_message));
|
||||
*/
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue