YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-04-01 18:25:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

aquatic_ws network: don't send error response when message parse fails

Browse source
This commit is contained in:
Joakim Frostegård 2021-10-16 18:07:00 +02:00
parent f32cb522e2
commit 1e66b18e52
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
TODO.md
View file

@ -6,6 +6,9 @@
* aquatic_http * aquatic_http
* aquatic_ws, including sending back new error responses * aquatic_ws, including sending back new error responses
* aquatic_ws: should it send back error on message parse error, or does that
just indicate that not enough data has been received yet?
* Consider turning on safety and override flags in mimalloc, mostly for * Consider turning on safety and override flags in mimalloc, mostly for
simd-json. It might be faster to just stop using simd-json if I consider simd-json. It might be faster to just stop using simd-json if I consider
it insecure, which it maybe isn't. it insecure, which it maybe isn't.

5
aquatic_ws/src/lib/network/mod.rs
View file

@ -237,7 +237,9 @@ pub fn run_handshakes_and_read_messages(
error!("InMessageSender: couldn't send message: {:?}", err); error!("InMessageSender: couldn't send message: {:?}", err);
} }
} }
Err(err) => { Err(_) => {
// FIXME: maybe this condition just occurs when enough data hasn't been recevied?
/*
info!("error parsing message: {:?}", err); info!("error parsing message: {:?}", err);
let out_message = OutMessage::ErrorResponse(ErrorResponse { let out_message = OutMessage::ErrorResponse(ErrorResponse {
@ -247,6 +249,7 @@ pub fn run_handshakes_and_read_messages(
}); });
local_responses.push((meta, out_message)); local_responses.push((meta, out_message));
*/
} }
} }
} }