YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-03-31 17:55:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

udp: ConnectionValidator: rename connection_id_eq_constant_time

Browse source
This commit is contained in:
Joakim Frostegård 2022-04-15 22:30:38 +02:00
parent 19c604d4f1
commit 22fa226f95
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
aquatic_udp/src/common.rs
View file

@ -65,7 +65,7 @@ impl ConnectionValidator {
let valid_until = connection_id.0.to_ne_bytes()[..4].try_into().unwrap();
// Check that recreating ConnectionId with same inputs yields identical hash.
if !Self::connection_id_eq_constant_time(
if !Self::connection_id_eq(
connection_id,
self.create_connection_id_inner(valid_until, source_addr),
) {
@ -99,12 +99,12 @@ impl ConnectionValidator {
ConnectionId(i64::from_ne_bytes(connection_id_bytes))
}
/// Compare ConnectionIDs in constant time
/// Compare ConnectionIDs without breaking constant time requirements
///
/// Use this instead of PartialEq::eq to avoid optimizations breaking constant
/// time HMAC comparison.
#[cfg(target_arch = "x86_64")]
fn connection_id_eq_constant_time(a: ConnectionId, b: ConnectionId) -> bool {
fn connection_id_eq(a: ConnectionId, b: ConnectionId) -> bool {
let mut eq = 0u8;
unsafe {
@ -397,6 +397,6 @@ mod tests {
let a = ConnectionId(a);
let b = ConnectionId(b);
ConnectionValidator::connection_id_eq_constant_time(a, b) == (a == b)
ConnectionValidator::connection_id_eq(a, b) == (a == b)
}
}