aquatic_ws: deserialize InMessage with simd-json for performance

From 18% to 13% CPU time during load test run.

Criterion benchmark of deserialization got about 90% improvement.
This commit is contained in:
Joakim Frostegård 2020-08-11 06:32:51 +02:00
parent 539cf03f93
commit 5d40954936
11 changed files with 1098 additions and 1031 deletions

View file

@ -18,6 +18,7 @@ anyhow = "1"
hashbrown = { version = "0.8", features = ["serde"] }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
simd-json = "0.3"
tungstenite = "0.11"
[dev-dependencies]

View file

@ -37,10 +37,10 @@ pub fn bench(c: &mut Criterion) {
offer_id: Some(OfferId(info_hash.0))
});
let ws_message = request.to_ws_message();
let mut ws_message = request.to_ws_message();
c.bench_function("deserialize-announce-request", |b| b.iter(||
InMessage::from_ws_message(black_box(&ws_message))
InMessage::from_ws_message(black_box(&mut ws_message))
));
}

View file

@ -258,16 +258,18 @@ pub enum InMessage {
impl InMessage {
#[inline]
pub fn from_ws_message(ws_message: &tungstenite::Message) -> ::anyhow::Result<Self> {
use tungstenite::Message::{Text, Binary};
pub fn from_ws_message(
ws_message: &mut tungstenite::Message
) -> ::anyhow::Result<Self> {
use tungstenite::Message::Text;
let text = match ws_message {
Text(text) => text,
Binary(bytes) => ::std::str::from_utf8(bytes)?,
_ => return Err(anyhow::anyhow!("Message is neither text nor bytes")),
let text: &mut str = if let Text(text) = ws_message {
text
} else {
return Err(anyhow::anyhow!("Message is not text"));
};
::serde_json::from_str(text).context("serialize with serde")
::simd_json::serde::from_str(text).context("deserialize with serde")
}
pub fn to_ws_message(&self) -> ::tungstenite::Message {
@ -521,9 +523,9 @@ mod tests {
#[quickcheck]
fn quickcheck_serde_identity_in_message(in_message_1: InMessage) -> bool {
let ws_message = in_message_1.to_ws_message();
let mut ws_message = in_message_1.to_ws_message();
let in_message_2 = InMessage::from_ws_message(&ws_message).unwrap();
let in_message_2 = InMessage::from_ws_message(&mut ws_message).unwrap();
let success = in_message_1 == in_message_2;
@ -660,4 +662,4 @@ mod tests {
success
}
}
}

View file

@ -1 +1 @@
{"mean":{"confidence_interval":{"confidence_level":0.95,"lower_bound":18703.904042751496,"upper_bound":18792.03205243071},"point_estimate":18746.072800173675,"standard_error":22.574908262590952},"median":{"confidence_interval":{"confidence_level":0.95,"lower_bound":18547.912025316455,"upper_bound":18605.846380105744},"point_estimate":18576.281397429004,"standard_error":15.686062550253332},"median_abs_dev":{"confidence_interval":{"confidence_level":0.95,"lower_bound":306.28255537969375,"upper_bound":380.480602345445},"point_estimate":338.0236020241898,"standard_error":19.790518378924638},"slope":{"confidence_interval":{"confidence_level":0.95,"lower_bound":18658.020869749234,"upper_bound":18761.405070764362},"point_estimate":18706.576690779686,"standard_error":26.604673332450176},"std_dev":{"confidence_interval":{"confidence_level":0.95,"lower_bound":553.3799052716993,"upper_bound":868.3032654487926},"point_estimate":715.2362082741504,"standard_error":80.39906836878366}}
{"mean":{"confidence_interval":{"confidence_level":0.95,"lower_bound":2094.926862805663,"upper_bound":2106.4267028892173},"point_estimate":2100.4015350320765,"standard_error":2.9392946950512737},"median":{"confidence_interval":{"confidence_level":0.95,"lower_bound":2085.6324189161965,"upper_bound":2087.229197620325},"point_estimate":2086.413383946413,"standard_error":0.4169721177244358},"median_abs_dev":{"confidence_interval":{"confidence_level":0.95,"lower_bound":16.490233538836364,"upper_bound":21.81096312849954},"point_estimate":18.680703664212437,"standard_error":1.3102508160911694},"slope":{"confidence_interval":{"confidence_level":0.95,"lower_bound":2085.6033212698335,"upper_bound":2094.8775402138917},"point_estimate":2089.9275901786054,"standard_error":2.361080413460781},"std_dev":{"confidence_interval":{"confidence_level":0.95,"lower_bound":73.7250326777399,"upper_bound":111.45831108639615},"point_estimate":93.04040248967267,"standard_error":9.710703224470429}}

File diff suppressed because one or more lines are too long

View file

@ -1 +1 @@
[16630.874818319186,17501.98981446029,19824.96313750323,20696.078133644332]
[1994.3859525202693,2034.7983478769509,2142.5647354947687,2182.97713085145]