From 6018450414bed0ef80a0ba99df8d928b4e613079 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Frosteg=C3=A5rd?= Date: Sun, 2 Aug 2020 00:46:47 +0200 Subject: [PATCH] aquatic_udp: stop reregistering socket --- TODO.md | 4 +++- aquatic_udp/src/lib/network.rs | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/TODO.md b/TODO.md index 8a3b528..e991eaf 100644 --- a/TODO.md +++ b/TODO.md @@ -41,13 +41,15 @@ doesn't seem to be that expensive (1-2% cpu) ## aquatic_udp -* mio: set oneshot for epoll and kqueue? otherwise, stop reregistering? * handle errors similarily to aquatic_ws, including errors in socket workers * More tests? * Protocol crate: converter functions should be trait functions # Not important +## General +* mio oneshot setting: could it be beneficial? + ## aquatic_http * request parsing: * smartstring: maybe use for keys? maybe use less? needs benchmarking diff --git a/aquatic_udp/src/lib/network.rs b/aquatic_udp/src/lib/network.rs index 3a74708..4ae642b 100644 --- a/aquatic_udp/src/lib/network.rs +++ b/aquatic_udp/src/lib/network.rs @@ -68,10 +68,6 @@ pub fn run_socket_worker( } state.statistics.readable_events.fetch_add(1, Ordering::SeqCst); - - poll.registry() - .reregister(&mut socket, token, interests) - .unwrap(); } }