From 656efc7d4eb5170bf9ede641b8b99f86701987a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Frosteg=C3=A5rd?= Date: Sat, 4 Jul 2020 13:55:15 +0200 Subject: [PATCH] Update TODO --- TODO.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/TODO.md b/TODO.md index b8a9fc4..2b9122f 100644 --- a/TODO.md +++ b/TODO.md @@ -6,30 +6,28 @@ and maybe run scripts should be adjusted ## aquatic_http -* use Either with peer addr, or key if it was sent, as part of peer map key? - Another option would be to generate unique trackerid, send it back and - demand that it's set (make it part of the peer map key), but I don't know - if it is supported in all clients. -* 'left' optional in magnet requests? Probably not. Transmission sends huge - positive number. * test with real clients * test tls * current serialized byte strings valid? need to test torrent transfer to find out -* request parsing in protocol module instead of in network, maybe from byte - buffer? Not obvious what error return type to use then (anyhow maybe?) * scrape: does it work with multiple hashes? +* StreamEnded isn't really an error and should really only be debug-logged * non-compact peers for ipv6 generally: use ResponsePeerList enum * on ipv6, compact=1 should result in error response * on ipv4, compact=0 should result in error response * what does supportcrypto key do? Request upgrade to TLS? -* StreamEnded isn't really an error and should really only be debug-logged + +### less important +* request parsing in protocol module instead of in network, maybe from byte + buffer? Not obvious what error return type to use then (anyhow maybe?) * log more info for all log modes (function location etc)? also for aquatic_ws * move stuff to common crate with ws? * serialization for future load tester: write custom non-serde serializer for url encode support maybe, or possibly existing crates handle byte serialization well (then there would still be the question of multiple values per key for scrape requests) +* 'left' optional in magnet requests? Probably not. Transmission sends huge + positive number. ## aquatic_ws * is 'key' sent in announce request? if so, maybe handle it like in