YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-04-01 10:15:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

aquatic_http_protocol: urlencode/urldecode Request.key

Browse source 
About 11% performance regression for Request::from_bytes
This commit is contained in:
Joakim Frostegård 2020-08-10 04:37:01 +02:00
parent 0a0b57a9e8
commit 74a538963f
7 changed files with 1014 additions and 1007 deletions
Download patch file Download diff file Expand all files Collapse all files

7
aquatic_http_protocol/src/request.rs
View file

@ -52,7 +52,7 @@ impl AnnounceRequest {
if let Some(ref key) = self.key {
output.write_all(b"&key=")?;
output.write_all(key.as_str().as_bytes())?;
output.write_all(::urlencoding::encode(key.as_str()).as_bytes())?;
}
output.write_all(b" HTTP/1.1\r\nConnection: keep-alive\r\n\r\n")?;
@ -220,7 +220,7 @@ impl Request {
if value.len() > 100 {
return Err(anyhow::anyhow!("'key' is too long"))
}
opt_key = Some(value.into());
opt_key = Some(::urlencoding::decode(value)?.into());
},
k => {
::log::info!("ignored unrecognized key: {}", k)
@ -360,8 +360,7 @@ mod tests {
fn quickcheck_serde_identity_request(){
fn prop(request: Request) -> TestResult {
if let Request::Announce(AnnounceRequest { key: Some(ref key), ..}) = request {
if !key.is_ascii(){
// Only ascii allowed in headers
if key.len() > 30 {
return TestResult::discard();
}
}