YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-03-31 17:55:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

udp: disallow announce requests with port value of 0

Browse source
This commit is contained in:
Joakim Frostegård 2024-02-02 14:08:08 +01:00
parent c48a83b06a
commit 97688ed074
2 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -39,6 +39,7 @@
#### Fixed #### Fixed
* Quit whole application if any worker thread quits * Quit whole application if any worker thread quits
* Disallow announce requests with port value of 0
### aquatic_http ### aquatic_http

14
crates/udp_protocol/src/request.rs
View file

@ -58,15 +58,21 @@ impl Request {
let request = AnnounceRequest::read_from_prefix(bytes) let request = AnnounceRequest::read_from_prefix(bytes)
.ok_or_else(|| RequestParseError::unsendable_text("invalid data"))?; .ok_or_else(|| RequestParseError::unsendable_text("invalid data"))?;
// Make sure not to create AnnounceEventBytes with invalid value if request.port.0.get() == 0 {
if matches!(request.event.0.get(), (0..=3)) { Err(RequestParseError::sendable_text(
Ok(Request::Announce(request)) "Port can't be 0",
} else { request.connection_id,
request.transaction_id,
))
} else if !matches!(request.event.0.get(), (0..=3)) {
// Make sure not to allow AnnounceEventBytes with invalid value
Err(RequestParseError::sendable_text( Err(RequestParseError::sendable_text(
"Invalid announce event", "Invalid announce event",
request.connection_id, request.connection_id,
request.transaction_id, request.transaction_id,
)) ))
} else {
Ok(Request::Announce(request))
} }
} }
// Scrape // Scrape