From dfcf84adde03cc6baa18327c365fbb49381bbb23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Frosteg=C3=A5rd?= Date: Fri, 9 Feb 2024 00:54:14 +0100 Subject: [PATCH] bencher: improve CpuMode docs --- crates/bencher/src/common.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/crates/bencher/src/common.rs b/crates/bencher/src/common.rs index ec98e7c..968e108 100644 --- a/crates/bencher/src/common.rs +++ b/crates/bencher/src/common.rs @@ -168,12 +168,20 @@ impl TryFrom> for TaskSetCpuIndicator { #[derive(Debug, Clone, Copy, clap::ValueEnum)] pub enum CpuMode { /// For 8 vCPU processor, use vCPU groups 0, 1, 2, 3, 4, 5, 6 and 7 + /// + /// Suitable for bare-metal machines without hyperthreads/SMT. Subsequent, /// For 8 vCPU processor, use vCPU groups 0 & 4, 1 & 5, 2 & 6 and 3 & 7 + /// + /// Suitable for bare-metal machines with hyperthreads/SMT. SplitPairs, /// For 8 vCPU processor, use vCPU groups 0 & 1, 2 & 3, 4 & 5 and 6 & 7 SubsequentPairs, /// For 8 vCPU processor, use vCPU groups 0, 2, 4 and 6 + /// + /// Suitable for somewhat fairly comparing trackers on Hetzner virtual + /// machines. Since in-VM hyperthreads aren't really hyperthreads, + /// enabling them causes unpredictable performance. SubsequentOnePerPair, }