YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-04-02 02:35:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update TODO

Browse source
This commit is contained in:
Joakim Frostegård 2020-05-17 12:08:41 +02:00
parent 4216452fc9
commit ea85f23ac7
1 changed files with 20 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

43
TODO.md
View file

@ -1,9 +1,7 @@
# TODO # TODO
Set default server addresses to 0.0.0.0! (or maybe ipv6 equivalent, which I
think is `[::]`). Update README default configs
## aquatic_ws ## aquatic_ws
* ipv4 / ipv6 split state?
* network * network
* handle tls certificate parse errors etc better * handle tls certificate parse errors etc better
* parse once only * parse once only
@ -12,11 +10,22 @@ think is `[::]`). Update README default configs
* send/recv buffer size config * send/recv buffer size config
* limit ws message sizes? * limit ws message sizes?
* privdrop * privdrop
* config
* make HandshakeHandler non-public ## aquatic_udp
* some config.network fields are actually used in handler. maybe they should * mio: set oneshot for epoll and kqueue? otherwise, stop reregistering?
be checked while parsing? not completely clear * Handle Ipv4 and Ipv6 peers. Probably split torrent state. Ipv4 peers
* ipv4 / ipv6 split state? can't make use of Ipv6 ones. Ipv6 ones may or may note be able to make
use of Ipv4 ones, I have to check.
* More tests?
## bittorrent_udp
* Tests with good known byte sequences (requests and responses)
# Not important
## aquatic_ws
* some config.network fields are actually used in handler. maybe they should
be checked while parsing? not completely clear
* "close connection" message from handler on peer_id and socket_addr mismatch? * "close connection" message from handler on peer_id and socket_addr mismatch?
Probably not really necessary. If it is an honest mistake, peer will just Probably not really necessary. If it is an honest mistake, peer will just
keep announcing and after a few minutes, the peer in the map will be cleaned keep announcing and after a few minutes, the peer in the map will be cleaned
@ -24,23 +33,11 @@ think is `[::]`). Update README default configs
* log crate instead of println/eprintln? * log crate instead of println/eprintln?
## aquatic_udp ## aquatic_udp
* if socket workers panic while binding, don't sit around and wait for them
in privdrop function. Maybe wait some maximum amount of time?
* mio: set oneshot for epoll and kqueue? otherwise, stop reregistering?
* Handle Ipv4 and Ipv6 peers. Probably split torrent state. Ipv4 peers
can't make use of Ipv6 ones. Ipv6 ones may or may note be able to make
use of Ipv4 ones, I have to check.
* More tests?
* Does it really make sense to include peer address in peer map key? I have * Does it really make sense to include peer address in peer map key? I have
to think about why I included it in the first place. to think about why I included it in the first place.
* if socket workers panic while binding, don't sit around and wait for them
## bittorrent_udp in privdrop function. Maybe wait some maximum amount of time?
* Tests with good known byte sequences (requests and responses)
# Not important
## aquatic_udp
* No overflow on instant + duration arithmetic now, hopefully? Possibly, * No overflow on instant + duration arithmetic now, hopefully? Possibly,
checked_add should be used. checked_add should be used.
* extract_response_peers * extract_response_peers