From 0c75da793ff9d4dde0a343ee680e79b29bf77a72 Mon Sep 17 00:00:00 2001
From: yggverse <yggverse@project>
Date: Tue, 25 Mar 2025 03:26:39 +0200
Subject: [PATCH] add missed tests members, enshort local var names

---
 .../response/certificate/not_authorized.rs       | 16 ++++++++++------
 .../connection/response/certificate/not_valid.rs | 16 ++++++++++------
 .../connection/response/certificate/required.rs  | 16 ++++++++++------
 3 files changed, 30 insertions(+), 18 deletions(-)

diff --git a/src/client/connection/response/certificate/not_authorized.rs b/src/client/connection/response/certificate/not_authorized.rs
index 0c73ae7..b10d6ff 100644
--- a/src/client/connection/response/certificate/not_authorized.rs
+++ b/src/client/connection/response/certificate/not_authorized.rs
@@ -59,13 +59,17 @@ impl NotAuthorized {
 #[test]
 fn test() {
     // ok
-    let not_authorized = NotAuthorized::from_utf8("61 Not Authorized\r\n".as_bytes()).unwrap();
-    assert_eq!(not_authorized.message(), Some("Not Authorized"));
-    assert_eq!(not_authorized.as_str(), "61 Not Authorized\r\n");
+    let na = NotAuthorized::from_utf8("61 Not Authorized\r\n".as_bytes()).unwrap();
+    assert_eq!(na.message(), Some("Not Authorized"));
+    assert_eq!(na.message_or_default(), "Not Authorized");
+    assert_eq!(na.as_str(), "61 Not Authorized\r\n");
+    assert_eq!(na.as_bytes(), "61 Not Authorized\r\n".as_bytes());
 
-    let not_authorized = NotAuthorized::from_utf8("61\r\n".as_bytes()).unwrap();
-    assert_eq!(not_authorized.message(), None);
-    assert_eq!(not_authorized.as_str(), "61\r\n");
+    let na = NotAuthorized::from_utf8("61\r\n".as_bytes()).unwrap();
+    assert_eq!(na.message(), None);
+    assert_eq!(na.message_or_default(), DEFAULT_MESSAGE);
+    assert_eq!(na.as_str(), "61\r\n");
+    assert_eq!(na.as_bytes(), "61\r\n".as_bytes());
 
     // err
     assert!(NotAuthorized::from_utf8("62 Fail\r\n".as_bytes()).is_err());
diff --git a/src/client/connection/response/certificate/not_valid.rs b/src/client/connection/response/certificate/not_valid.rs
index 58198a8..94e847c 100644
--- a/src/client/connection/response/certificate/not_valid.rs
+++ b/src/client/connection/response/certificate/not_valid.rs
@@ -59,13 +59,17 @@ impl NotValid {
 #[test]
 fn test() {
     // ok
-    let not_valid = NotValid::from_utf8("62 Not Valid\r\n".as_bytes()).unwrap();
-    assert_eq!(not_valid.message(), Some("Not Valid"));
-    assert_eq!(not_valid.as_str(), "62 Not Valid\r\n");
+    let nv = NotValid::from_utf8("62 Not Valid\r\n".as_bytes()).unwrap();
+    assert_eq!(nv.message(), Some("Not Valid"));
+    assert_eq!(nv.message_or_default(), "Not Valid");
+    assert_eq!(nv.as_str(), "62 Not Valid\r\n");
+    assert_eq!(nv.as_bytes(), "62 Not Valid\r\n".as_bytes());
 
-    let not_valid = NotValid::from_utf8("62\r\n".as_bytes()).unwrap();
-    assert_eq!(not_valid.message(), None);
-    assert_eq!(not_valid.as_str(), "62\r\n");
+    let nv = NotValid::from_utf8("62\r\n".as_bytes()).unwrap();
+    assert_eq!(nv.message(), None);
+    assert_eq!(nv.message_or_default(), DEFAULT_MESSAGE);
+    assert_eq!(nv.as_str(), "62\r\n");
+    assert_eq!(nv.as_bytes(), "62\r\n".as_bytes());
 
     // err
     // @TODO assert!(NotValid::from_utf8("62Fail\r\n".as_bytes()).is_err());
diff --git a/src/client/connection/response/certificate/required.rs b/src/client/connection/response/certificate/required.rs
index 105185a..b44585c 100644
--- a/src/client/connection/response/certificate/required.rs
+++ b/src/client/connection/response/certificate/required.rs
@@ -59,13 +59,17 @@ impl Required {
 #[test]
 fn test() {
     // ok
-    let required = Required::from_utf8("60 Required\r\n".as_bytes()).unwrap();
-    assert_eq!(required.message(), Some("Required"));
-    assert_eq!(required.as_str(), "60 Required\r\n");
+    let r = Required::from_utf8("60 Required\r\n".as_bytes()).unwrap();
+    assert_eq!(r.message(), Some("Required"));
+    assert_eq!(r.message_or_default(), "Required");
+    assert_eq!(r.as_str(), "60 Required\r\n");
+    assert_eq!(r.as_bytes(), "60 Required\r\n".as_bytes());
 
-    let required = Required::from_utf8("60\r\n".as_bytes()).unwrap();
-    assert_eq!(required.message(), None);
-    assert_eq!(required.as_str(), "60\r\n");
+    let r = Required::from_utf8("60\r\n".as_bytes()).unwrap();
+    assert_eq!(r.message(), None);
+    assert_eq!(r.message_or_default(), DEFAULT_MESSAGE);
+    assert_eq!(r.as_str(), "60\r\n");
+    assert_eq!(r.as_bytes(), "60\r\n".as_bytes());
 
     // err
     assert!(Required::from_utf8("62 Fail\r\n".as_bytes()).is_err());