Compare commits

..

13 commits
0.18.0 ... main

Author SHA1 Message Date
yggverse
11d17e004e update version 2025-11-07 21:15:20 +02:00
yggverse
bba51e38e8 apply fmt updates 2025-10-19 22:46:49 +03:00
yggverse
0f6eaa563c update version 2025-10-19 22:38:51 +03:00
yggverse
7e9ecf64b3 implement default trait 2025-10-19 22:37:48 +03:00
yggverse
f8537e4ab6 use latest dependencies version 2025-07-23 05:08:13 +03:00
yggverse
5019e66667 use latest 0.20 api 2025-07-23 04:29:01 +03:00
yggverse
d8e0a8e35a update dependencies version 2025-07-23 03:07:24 +03:00
yggverse
c5d10e020a return Connection on Request error 2025-07-23 01:27:20 +03:00
yggverse
e878fe4ba2 return NetworkAddress on Error::Connect 2025-07-22 09:49:39 +03:00
yggverse
cc1018224a reorganize error types, return socket_connection on init error 2025-07-22 09:46:32 +03:00
yggverse
44196608ce implement optional TOFU validation 2025-07-22 08:48:56 +03:00
yggverse
bb5b1dfb53 apply clippy optimizations 2025-07-22 08:44:50 +03:00
yggverse
c79f386bf1 update version 2025-03-28 00:33:33 +02:00
8 changed files with 78 additions and 34 deletions

View file

@ -1,6 +1,6 @@
[package]
name = "ggemini"
version = "0.18.0"
version = "0.20.1"
edition = "2024"
license = "MIT"
readme = "README.md"
@ -11,10 +11,10 @@ repository = "https://github.com/YGGverse/ggemini"
[dependencies.gio]
package = "gio"
version = "0.20.9"
version = "0.21.0"
features = ["v2_70"]
[dependencies.glib]
package = "glib"
version = "0.20.9"
version = "0.21.0"
features = ["v2_66"]

View file

@ -55,7 +55,8 @@ fn main() -> ExitCode {
},
Priority::DEFAULT,
Cancellable::new(),
None, // optional `GTlsCertificate`
None, // optional auth `GTlsCertificate`
None, // optional TOFU `GTlsCertificate` array
|result| match result {
Ok((response, _connection)) => match response {
Response::Success(success) => match success.mime().unwrap().as_str() {

View file

@ -59,7 +59,8 @@ impl Client {
request: Request,
priority: Priority,
cancellable: Cancellable,
certificate: Option<TlsCertificate>,
client_certificate: Option<TlsCertificate>,
server_certificates: Option<Vec<TlsCertificate>>,
callback: impl FnOnce(Result<(Response, Connection), Error>) + 'static,
) {
// Begin new connection
@ -73,30 +74,33 @@ impl Client {
move |result| match result {
Ok(socket_connection) => {
match Connection::build(
socket_connection,
socket_connection.clone(),
network_address,
certificate,
client_certificate,
server_certificates,
is_session_resumption,
) {
Ok(connection) => connection.request_async(
Ok(connection) => connection.clone().request_async(
request,
priority,
cancellable,
move |result| {
callback(match result {
Ok(response) => Ok(response),
Err(e) => Err(Error::Connection(e)),
Err(e) => Err(Error::Request(connection, e)),
})
},
),
Err(e) => callback(Err(Error::Connection(e))),
Err(e) => {
callback(Err(Error::Connection(socket_connection, e)))
}
}
}
Err(e) => callback(Err(Error::Connect(e))),
Err(e) => callback(Err(Error::Connect(network_address, e))),
}
})
}
Err(e) => callback(Err(Error::Request(e))),
Err(e) => callback(Err(Error::NetworkAddress(e))),
}
}

View file

@ -6,17 +6,16 @@ pub use error::Error;
pub use request::{Mode, Request};
pub use response::Response;
// Local dependencies
use gio::{
Cancellable, IOStream, NetworkAddress, SocketConnection, TlsCertificate, TlsClientConnection,
prelude::{IOStreamExt, OutputStreamExtManual, TlsConnectionExt},
prelude::{IOStreamExt, OutputStreamExtManual, TlsCertificateExt, TlsConnectionExt},
};
use glib::{
Bytes, Priority,
object::{Cast, ObjectExt},
};
#[derive(Debug, Clone)]
pub struct Connection {
pub network_address: NetworkAddress,
pub socket_connection: SocketConnection,
@ -30,17 +29,19 @@ impl Connection {
pub fn build(
socket_connection: SocketConnection,
network_address: NetworkAddress,
certificate: Option<TlsCertificate>,
client_certificate: Option<TlsCertificate>,
server_certificates: Option<Vec<TlsCertificate>>,
is_session_resumption: bool,
) -> Result<Self, Error> {
Ok(Self {
tls_client_connection: match new_tls_client_connection(
&socket_connection,
Some(&network_address),
server_certificates,
is_session_resumption,
) {
Ok(tls_client_connection) => {
if let Some(ref c) = certificate {
if let Some(ref c) = client_certificate {
tls_client_connection.set_certificate(c);
}
tls_client_connection
@ -136,6 +137,7 @@ impl Connection {
fn new_tls_client_connection(
socket_connection: &SocketConnection,
server_identity: Option<&NetworkAddress>,
server_certificates: Option<Vec<TlsCertificate>>,
is_session_resumption: bool,
) -> Result<TlsClientConnection, Error> {
match TlsClientConnection::new(socket_connection, server_identity) {
@ -149,9 +151,19 @@ fn new_tls_client_connection(
// https://geminiprotocol.net/docs/protocol-specification.gmi#closing-connections
tls_client_connection.set_require_close_notify(true);
// @TODO validate
// https://geminiprotocol.net/docs/protocol-specification.gmi#tls-server-certificate-validation
tls_client_connection.connect_accept_certificate(|_, _, _| true);
// [TOFU](https://geminiprotocol.net/docs/protocol-specification.gmi#tls-server-certificate-validation)
tls_client_connection.connect_accept_certificate(move |_, c, _| {
server_certificates
.as_ref()
.is_none_or(|server_certificates| {
for server_certificate in server_certificates {
if server_certificate.is_same(c) {
return true;
}
}
false
})
});
Ok(tls_client_connection)
}

View file

@ -2,22 +2,29 @@ use std::fmt::{Display, Formatter, Result};
#[derive(Debug)]
pub enum Error {
Connect(glib::Error),
Connection(crate::client::connection::Error),
Request(crate::client::connection::request::Error),
Connect(gio::NetworkAddress, glib::Error),
Connection(gio::SocketConnection, crate::client::connection::Error),
NetworkAddress(crate::client::connection::request::Error),
Request(
crate::client::connection::Connection,
crate::client::connection::Error,
),
}
impl Display for Error {
fn fmt(&self, f: &mut Formatter) -> Result {
match self {
Self::Connection(e) => {
write!(f, "Connection error: {e}")
}
Self::Connect(e) => {
Self::Connect(_, e) => {
write!(f, "Connect error: {e}")
}
Self::Request(e) => {
write!(f, "Request error: {e}")
Self::Connection(_, e) => {
write!(f, "Connection init error: {e}")
}
Self::NetworkAddress(e) => {
write!(f, "Network address error: {e}")
}
Self::Request(_, e) => {
write!(f, "Connection error: {e}")
}
}
}

View file

@ -33,13 +33,13 @@ pub fn from_stream_async(
size.total += bytes.len();
on_chunk(bytes.clone(), size.total);
if let Some(limit) = size.limit {
if size.total > limit {
return on_complete(Err(Error::BytesTotal(size.total, limit)));
}
if let Some(limit) = size.limit
&& size.total > limit
{
return on_complete(Err(Error::BytesTotal(size.total, limit)));
}
if bytes.len() == 0 {
if bytes.is_empty() {
return on_complete(Ok((file_output_stream, size.total)));
}

View file

@ -5,3 +5,13 @@ pub struct Size {
pub limit: Option<usize>,
pub total: usize,
}
impl Default for Size {
fn default() -> Self {
Self {
chunk: 0x10000, // 64KB
limit: None,
total: 0,
}
}
}

View file

@ -4,3 +4,13 @@ pub struct Size {
pub limit: usize,
pub total: usize,
}
impl Default for Size {
fn default() -> Self {
Self {
chunk: 0x10000, // 64KB
limit: 0xfffff, // 1 MB
total: 0,
}
}
}