YGGverse/aquatic
1
0
Fork 0
mirror of https://github.com/YGGverse/aquatic.git synced 2026-03-31 17:55:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

aquatic_udp: stop reregistering socket

Browse source
This commit is contained in:
Joakim Frostegård 2020-08-02 00:46:47 +02:00
parent fb850170c4
commit 6018450414
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
TODO.md
View file

@ -41,13 +41,15 @@
doesn't seem to be that expensive (1-2% cpu) doesn't seem to be that expensive (1-2% cpu)
## aquatic_udp ## aquatic_udp
* mio: set oneshot for epoll and kqueue? otherwise, stop reregistering?
* handle errors similarily to aquatic_ws, including errors in socket workers * handle errors similarily to aquatic_ws, including errors in socket workers
* More tests? * More tests?
* Protocol crate: converter functions should be trait functions * Protocol crate: converter functions should be trait functions
# Not important # Not important
## General
* mio oneshot setting: could it be beneficial?
## aquatic_http ## aquatic_http
* request parsing: * request parsing:
* smartstring: maybe use for keys? maybe use less? needs benchmarking * smartstring: maybe use for keys? maybe use less? needs benchmarking

4
aquatic_udp/src/lib/network.rs
View file

@ -68,10 +68,6 @@ pub fn run_socket_worker(
} }
state.statistics.readable_events.fetch_add(1, Ordering::SeqCst); state.statistics.readable_events.fetch_add(1, Ordering::SeqCst);
poll.registry()
.reregister(&mut socket, token, interests)
.unwrap();
} }
} }