aquatic/TODO.md

# TODO

## General

* have main thread wait for any of the threads returning, quit
  if that is the since since it means a panic occured
* automatic tests running real clients in container?

## aquatic_http_load_test

* do single peer_id per connection as in ws, can't hurt and might fix
  opentracker issues
* multiple workers is broken
* try creating sockets with different ports (and also local ips if setting
  enabled), then converting them to mio tcp streams
* really break and remove connection when reading 0 bytes?
* think about how to fully load opentracker. maybe keepalive can be activated
* maybe check against other well-known implementations (which hopefully
  do keep-alive)
* Don't send keepalive header, it is not necessary with HTTP/1.1? (But
  opentracker might want it)

## aquatic_http
* check if connection ValidUntil's are really updated when necessary. there
  are some connections dropped after a while when load testing
* add tests
  * test response serialization (against data known to be good would be nice)
  * test request parsing with strange/bad inputs, with and without quickcheck
* test torrent transfer with real clients
  * test tls
  * scrape: does it work (serialization etc), and with multiple hashes?
  * 'left' optional in magnet requests? Probably not. Transmission sends huge
    positive number.
* compact=0 should result in error response
* config: multiple request workers
* Connection.send_response: handle case when all bytes are not written: can
  write actually block here? And what action should be taken then?

## aquatic_ws
* use mio waker, wake it when sending OutMessage's to socket workers? Not
  necessarily very beneficial since this sending is batched anyway. A benefit
  would be enabling setting poll timeout much higher so periods without
  traffic don't really activate the CPU
* what does numwant do in reference tracker? number of offers to send, right?
* test transfer again with changes made:
  * crossbeam-channel
  * ipv6/ipv4 mapping
  * tungstenite 0.11
* is 'key' sent in announce request? if so, maybe handle it like in
  aquatic_http (including ip uniqueness part of peer map key)
* config: multiple request workers
* optimize serialize_20_bytes (10% cpu utilization). deserialize_20_bytes
  doesn't seem to be that expensive (1-2% cpu)

## aquatic_ws_load_test
* still maybe too few answers received with aquatic_ws
* why does wt-tracker freak out when numwant is set to offers.len()? lots
  of broken pipe errors etc. likely because it sends offers when it is set.
* wt-tracker: why lots of responses with no (new) requests?
* offers_per_request or similar config var
* consider writing custom serializers, they take up lots of time now
* count number of announce requests sent, total number of offers sent,
  and answers sent. compare these with responses received. same for
  scrape requests I suppose.

## aquatic_udp
* handle errors similarily to aquatic_ws, including errors in socket workers
  and using log crate
* use key from request as part of peer map key like in aquatic_http? need to
  check protocol specification

# Not important

## General
* mio oneshot setting: could it be beneficial? I think not, I think it is
  only useful when there are multiple references to a fd, which shouldn't
  be the case?
* peer extractor: extract one extra, remove peer if same as sender, otherwise
  just remove one?

## aquatic_http
* request parsing:
  * smartstring: maybe use for keys? maybe use less? needs benchmarking
* use fastrand instead of rand? (also for ws and udp then I guess because of
  shared function)
* use smartstring for failure response reason?
* log more info for all log modes (function location etc)? also for aquatic_ws
* Support supportcrypto/requirecrypto keys? Official extension according to
  https://wiki.theory.org/index.php/BitTorrentSpecification#Connection_Obfuscation.
  More info: http://wiki.vuze.com/w/Message_Stream_Encryption. The tricky part
  is finding supportcrypto peers (and even better requirecrypto peers) to send
  back to requirecrypto peers. Doesn't really work according to reference in
  https://en.wikipedia.org/wiki/BitTorrent_protocol_encryption

## aquatic_ws
* use enum as return type for handshake machine
* copyless for vec pushes in request handler, instead of stack and then heap?
* config
  * send/recv buffer size?
  * tcp backlog?
  * some config.network fields are actually used in handler. maybe they should
    be checked while parsing? not completely clear
* "close connection" message from handler on peer_id and socket_addr mismatch?
  Probably not really necessary. If it is an honest mistake, peer will just
  keep announcing and after a few minutes, the peer in the map will be cleaned
  out and everything will start working
* stack-allocated vectors for announce request offers and scrape request info
  hashes?
* write new version of extract_response_peers which checks for equality with
  peer sending request? It could return an arrayvec or smallvec by the way
  (but then the size needs to be adjusted together with the corresponding
  config var, or the config var needs to be removed)

## aquatic_udp

* Does it really make sense to include peer address in peer map key? I have
  to think about why I included it in the first place.
* if socket workers panic while binding, don't sit around and wait for them
  in privdrop function. Maybe wait some maximum amount of time?
* No overflow on instant + duration arithmetic now, hopefully? Possibly,
  checked_add should be used.
* extract_response_peers
    * Cleaner code
    * Stack-allocated vector?
* Performance
    * mialloc good?

## aquatic_udp_protocol
* Tests with good known byte sequences (requests and responses)
* Don't do endian conversion where unnecessary, such as for connection id and
  transaction id?

## aquatic_cli_helpers

* Include config field comments in exported toml (likely quite a bit of work)

# Don't do

## General - profile-guided optimization

Doesn't seem to improve performance, possibly because I only got it to compile
with thin LTO which could have impacted performance. Running non-pgo version
without AVX-512 seems to be the fastest, although the presence of a ctrl-c handler
(meaning the addition of a thread) might have worsed performance in pgo version
(unlikely).

Benchmarks of aquatic_udp with and without PGO. On hetzer 16x vCPU. 8 workers
just like best results in last benchmark, multiple client ips=true:

### target-cpu=native (probably with avx512 since such features are listed in /proc/cpuinfo), all with thin lto
*   With PGO on aquatic_udp: 370k, without 363k responses per second
*   With PGO on both aquatic_udp and aquatic_udp_load_test: 368k

### with target-cpu=skylake, all with thin lto
*   with pgo on aquatic_udp: 400k
*   with no pgo: 394k

### checkout master (no pgo, no thin lto, no ctrlc handler)

* target-cpu=native: 394k
* target-cpu=skylake: 439k
* no target-cpu set: 388k

## aquatic_http
* request from path:
  * deserialize 20 bytes: possibly rewrite (just check length of underlying
    bytes == 20 and then copy them), also maybe remove String from map for
    these cases too. doesn't really improve performance
  * crazy http parsing: check for newline with memchr, take slice until
    there. then iter over space newlines/just take relevant data. Not faster
    than httparse and a lot worse

## aquatic_http / aquatic_ws
* Shared state for HTTP with and without TLS. Peers who announce over TLS
  should be able to expect that someone snooping on the connection can't
  connect them to a info hash. If someone receives their IP in a response
  while announcing without TLS, this expectation would be broken.

## aquatic_udp

* Other HashMap hashers (such as SeaHash): seemingly not worthwhile, see
  `https://github.com/tkaitchuck/aHash`
* `sendmmsg`: can't send to multiple socket addresses, so doesn't help
* Config behind Arc in state: it is likely better to be able to pass it around
  without state
* Responses: make vectors iterator references so we dont have run .collect().
  Doesn't work since it means conversion to bytes must be done while holding
  readable reference to entry in torrent map, hurting concurrency.

## aquatic_udp_protocol

* Use `bytes` crate: seems to worsen performance somewhat
* Zerocopy (https://docs.rs/zerocopy/0.3.0/zerocopy/index.html) for requests
  and responses? Doesn't work on Vec etc
* New array buffer each time in response_to_bytes: doesn't help performance